ENH: Add global config manager #491
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #478
What does this implement/fix? Explain your changes.
This implements a global config manager for skbase as requested in issue #478.
It adds a global config system that allows setting config values globally, with priority order:
It also includes an extension point
__skbase_get_config__for downstream packages to provide their own global configs (e.g., for specific object types like forecasters in sktime).The implementation includes:
skbase.configmodule withget_config,set_config,reset_config,config_contextBaseObject.get_configwith the specified priorityDoes your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Any other comments?
This is based on the draft in #149 but adjusted to meet the exact requirements from #478, including the priority order and extension for object types.
PR checklist
For all contributions
For code contributions