[BUG] fixes and improvements to all_objects

[fkiraly]

This fixes some bugs and makes improvements to all_objects that are in sktime.

Bugs:

• subsetting should be via issubclass, not isinstance, since we filter classes, not objects. This seems to be correct in sktime but is wrong in skbase. Fixes [BUG] all_objects argument object_types does not work #71

Improvements:

• docstrings for modules_to_ignore parameters
• docstring of all_objects fixed to make reference to objects, not estimators

[codecov-commenter]

Codecov Report

Merging #69 (22ce6fc) into main (7135891) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files          16       16           
  Lines        1352     1352           
=======================================
  Hits          741      741           
  Misses        611      611           

Impacted Files	Coverage Δ
skbase/_lookup.py	42.21% <66.66%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[fkiraly]

maybe we should also add a test for this?

[RNKuhns]

@fkiraly there is still a bit of formatting weirdness in the all_object docstring when it renders in the read-the-docs check.

Do you mind taking a look at that and updating the format? I'm going to be opening up a separate PR for the tests.

[fkiraly]

Do you mind taking a look at that and updating the format? I'm going to be opening up a separate PR for the tests.

Just looked at it, looks ok to me?

I also did not change the general format or indentation, I think?

Do you mean the "note" boxes? I thought this was ok, but we can change the indentation.

[RNKuhns]

@fkiraly I'm fine leaving the docstring as is for now. I thought I was seeing one part bolded that didn't seem like it should be (the boxes always through me for a loop, but I get its an indentation thing). I think we have an open issue related to the docstring for this, but I'll double-check when I add the tests for lookup functionality.

[RNKuhns]

LGTM. Will merge and handle tests and potential tweak to docstring in forthcoming PR.