Skip to content

Update config files and remove use of setup.py#75

Merged
RNKuhns merged 13 commits into
sktime:mainfrom
RNKuhns:update_config_files
Nov 29, 2022
Merged

Update config files and remove use of setup.py#75
RNKuhns merged 13 commits into
sktime:mainfrom
RNKuhns:update_config_files

Conversation

@RNKuhns
Copy link
Copy Markdown
Contributor

@RNKuhns RNKuhns commented Nov 22, 2022

What does this implement/fix? Explain your changes.

This updates the project config files and removes use of setup.py.

@RNKuhns
Copy link
Copy Markdown
Contributor Author

RNKuhns commented Nov 22, 2022

@fkiraly we need to update our CodeCov settings to provide access to the new repository (skbase). The repository CodeCov is still being routed to the old CodeCov. This assumes that it is going to a CodeCov repo for skbase.

I don't see the ability to permission CodeCov to access skbase repo on my end. Let's take a look at this in our upcoming meeting.

@fkiraly
Copy link
Copy Markdown
Contributor

fkiraly commented Nov 22, 2022

odd - here's the settings I can see in the org:
image

i.e., it looks like the codecov app has access?

@RNKuhns RNKuhns requested a review from fkiraly November 25, 2022 04:53
@RNKuhns
Copy link
Copy Markdown
Contributor Author

RNKuhns commented Nov 29, 2022

@fkiraly the problem turned out to be with the need for "=" signs in the "addopts" configuration for pytest in the pyproject.toml versus other ways of specifying the configuration. This should be good to go, if it looks good to you.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #75 (389fbb6) into main (150a48f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files          16       16           
  Lines        1352     1352           
=======================================
  Hits          741      741           
  Misses        611      611           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go, and thanks for the diacritic.

@RNKuhns RNKuhns merged commit c3f5443 into sktime:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants