Fixes to issues identified by CodeQL Scanning#79
Merged
Conversation
RNKuhns
changed the title
fkiraly
reviewed
Nov 24, 2022
fkiraly
reviewed
Nov 24, 2022
fkiraly
approved these changes
Nov 24, 2022
Contributor
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
looks ok, assuming the mysterious URL related changes are unimportant.
Perhaps you can remove the commented code too?
Contributor
Author
Commented out code removed, since that part wasn't needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This includes 2 fixes to errors that were raised by #68. Fixing this will allow #68 to be merged.
Fixes call init on parent (BaseObject) in test classes. Also, updates conf.py to fix minor issues with unused variables.