Convert about page to sphinx-design#93
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 60.86% 60.86%
=======================================
Files 23 23
Lines 1477 1477
=======================================
Hits 899 899
Misses 578 578 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fkiraly
approved these changes
Dec 30, 2022
Contributor
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
tested it, links and panels work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #50
What does this implement/fix? Explain your changes.
Uses sphinx-design instead of sphinx-panel in the project's Sphinx docs. Sphinx-design provides a nicer design aesthetic and I believe sphinx-panel is no longer maintained.
Does your contribution introduce a new dependency? If yes, which one?
sphinx-design is a new documentatino dependency (instead of sphinx-panel).
What should a reviewer concentrate their feedback on?
Do the affected documentation pages render correctly and are the panels "clickable".