[DOC] delete dead documentation page docs/introduction.rst#1026
Merged
fkiraly merged 6 commits intoApr 4, 2026
Merged
Conversation
fkiraly
requested changes
Apr 2, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
This looks like a dead documentation page. This is from skpro 1.0, using methods that have been removed since.
Have you checked whether this is still live? If no, just delete the rst file. If yes, please replace by another example from the tutorial notebook.
Contributor
Author
|
Hi @fkiraly, thanks for the review! I checked and the introduction.rst file is not I will go ahead and delete the entire |
c6b8a9d to
430d716
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1025
What does this implement/fix? Explain your changes.
While going through the skpro codebase I noticed
the "boston data" link in docs/introduction.rst
was broken and pointing to a 404 page.
The link was pointing to:
http://scikit-learn.org/stable/modules/generated/sklearn.datasets.load_boston.html
This page no longer exists because sklearn
permanently removed load_boston in version 1.2
(2022) due to ethical concerns around the dataset.
Changes made in docs/introduction.rst:
housing dataset URL which is the official sklearn
replacement
california housing throughout the file
Does your contribution introduce a new dependency? If yes, which one?
No new dependencies introduced.
What should a reviewer concentrate their feedback on?
california housing correctly
Did you add any tests for the change?
No tests needed as this is a documentation
only change.
Any other comments?
While investigating this issue I also found
that docs/introduction.rst references two
example files via literalinclude directives:
Both files were deleted in PR #271 (Apr 2024)
but the references in docs/introduction.rst
were never removed. This will be raised as a
separate bug issue.
PR checklist
For all contributions
with any new badges I've earned :-)