[BUG] Fix missing negative sign in SPLL metric calculates negative loss for censored data#1032
Merged
Merged
Conversation
cf4f2e0 to
bac662f
Compare
fkiraly
approved these changes
Apr 9, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
Yes, this is indeed a typo. Thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fixes a mathematical sign error in the
SPLL(Survival Process Logarithmic Loss) metric calculation for censored data.In$\Delta = 1$ ) as:
$L = - \Delta \log d.S(y)$
_spll.py, the docstring correctly defines the loss for a censored instance (However, the implementation was missing negative sign for the discrete term:
Because$S(y) = 1 - CDF \le 1$ , its logarithm is inherently negative. Without the leading minus sign, the metric was returning a negative loss for censored instances. Since $S(y)=e^{-1}$ was returning a score of
lower_is_better=True, this should inadvertently reward models that assigned lower survival probabilities to censored data (e.g., an Exponential model predicting-1.0instead of1.0).Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Verification of the mathematical correction in
_spll.py.Did you add any tests for the change?
No, I have made a regression test but would like to discuss whether to add seperately or append in any of the tests .
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.