[BUG] fix MapieRegressor dependency check, and BaseProbaRegressor._predict_proba default#540
Merged
Conversation
fkiraly
added
bug
module:regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two unreported bugs:
MapieRegressordependency check was always failing due to the capitalization ofMAPIEon pypi - notmapie. This led to the estimator not being useable since the upgrade to strict PEP 440 (which included capitalization sensitivity) of thepython_dependenciestag.BaseProbaRegressor._predict_probasensible default would not work properly if the expected return ofpredictwas not apd.DataFrame. This has been remedied by using the idiomatic method_get_columnsto determine the column names.