[BUG] correct warning message for distribution cdf in approximate case#556
Merged
Conversation
fkiraly
requested review from
SaiRevanth25 and
felipeangelimvieira
as code owners
fkiraly
added
bug
module:probability&simulation
This reverts commit d7cd0ec.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a distribution
cdfdoes not have an analytical implementation, the fallback implementation from theBaseDistributionmay be called, which is a simple Monte Carlo estimate that will trigger a warning.However, the warning refers to the mean, and not the cdf - this is a mistake.
This PR fixes the error message.