Skip to content

[ENH] Moves epsilo offset logic to TruncatedDistribution from Hurdle#577

Merged
fkiraly merged 1 commit into
sktime:mainfrom
tingiskhan:fix/dists/truncated-not-working
Aug 4, 2025
Merged

[ENH] Moves epsilo offset logic to TruncatedDistribution from Hurdle#577
fkiraly merged 1 commit into
sktime:mainfrom
tingiskhan:fix/dists/truncated-not-working

Conversation

@tingiskhan
Copy link
Copy Markdown
Contributor

@tingiskhan tingiskhan commented Aug 2, 2025

Reference Issues/PRs

Fixes #566.

What does this implement/fix? Explain your changes.

Moves the epsilon offset logic for the Hurdle distribution to Truncated instead.

Does your contribution introduce a new dependency? If yes, which one?

No.

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

No.

Any other comments?

The tests pass locally, so I'm hoping this solves the issues.

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators labels Aug 4, 2025
@fkiraly fkiraly changed the title [ENH] Moves epsilon offset logic to TruncatedDistribution [ENH] Moves epsilo offset logic to TruncatedDistribution from Hurdle Aug 4, 2025
Copy link
Copy Markdown
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work!

@fkiraly fkiraly merged commit 07552bd into sktime:main Aug 4, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement module:probability&simulation probability distributions and simulators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Hurdle distribution sporadically fails test_ppf_and_cdf with "off-by-one" errors

2 participants