Skip to content

Conversation

@ParamThakkar123
Copy link
Contributor

Reference Issues/PRs

Fixes #98

What does this implement/fix? Explain your changes.

Added github actions workflows and a python script to add all contributors with labels to .allcontributorsrc

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

Though I would prefer if it does not happen at every PR, but on a CRON once a week.

May I suggest to take the sktime job update_contributors.yml as a template here?

Plus, should we be using the official npm package?

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Nov 17, 2025
@ParamThakkar123
Copy link
Contributor Author

Thanks, this is great!

Though I would prefer if it does not happen at every PR, but on a CRON once a week.

May I suggest to take the sktime job update_contributors.yml as a template here?

Plus, should we be using the official npm package?

Sure will make the change and use the official npm package instead !

@ParamThakkar123
Copy link
Contributor Author

I updated this PR to use update_contributors.yml as the template and changed it to a CRON job which will run every week

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.
Can you ensure there is a newline at the end of file?

@ParamThakkar123
Copy link
Contributor Author

@fkiraly Made the change!

@fkiraly fkiraly merged commit 842c2df into sktime:main Nov 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] set up allcontributors workflow

2 participants