-
Notifications
You must be signed in to change notification settings - Fork 74
[ENH] Added allcontributors workflow #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great!
Though I would prefer if it does not happen at every PR, but on a CRON once a week.
May I suggest to take the sktime job update_contributors.yml as a template here?
Plus, should we be using the official npm package?
Sure will make the change and use the official npm package instead ! |
|
I updated this PR to use |
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
Can you ensure there is a newline at the end of file?
|
@fkiraly Made the change! |
Reference Issues/PRs
Fixes #98
What does this implement/fix? Explain your changes.
Added github actions workflows and a python script to add all contributors with labels to .allcontributorsrc
Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.