Skip to content

[ENH] Extend KernelMixture to support 2D per-instance weights#841

Merged
fkiraly merged 1 commit into
sktime:mainfrom
patelchaitany:enh/kernel-mixture-2d-weights
Mar 10, 2026
Merged

[ENH] Extend KernelMixture to support 2D per-instance weights#841
fkiraly merged 1 commit into
sktime:mainfrom
patelchaitany:enh/kernel-mixture-2d-weights

Conversation

@patelchaitany
Copy link
Copy Markdown
Contributor

@patelchaitany patelchaitany commented Mar 9, 2026

Reference Issues/PRs

Fixes #836

What does this implement/fix? Explain your changes.

Extended KernelMixture to accept a 2D weights array of shape (n_instances, n_support), where each row provides a separate weight vector for each distribution instance. Previously, only 1D weights (shared across all instances) were supported.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

Signed-off-by: Chaitany patel <patelchaitany93@gmail.com>
Copy link
Copy Markdown
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fkiraly fkiraly merged commit 445c161 into sktime:main Mar 10, 2026
39 checks passed
@patelchaitany patelchaitany deleted the enh/kernel-mixture-2d-weights branch March 10, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement module:probability&simulation probability distributions and simulators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Extend KernelMixture to support 2D weights

2 participants