fix: get_test_params uses self instead of cls in several metric classes#876
Merged
fkiraly merged 1 commit intosktime:mainfrom Mar 13, 2026
Merged
Conversation
OmAmbole009
requested review from
felipeangelimvieira and
fkiraly
as code owners
Contributor
Author
|
Hi @fkiraly @felipeangelimvieira Review this Pr. |
fkiraly
approved these changes
Mar 11, 2026
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
That's right, thanks!
How did this not get detected by tests?
fkiraly
added
enhancement
module:metrics&benchmarking
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #875
What
Replaced
selfwithclsand addedparameter_set="default"argumentin
get_test_paramsclassmethods for four metric classes inskpro/metrics/_classes.py.Why
@classmethodmethods receive the class as first argument, which byconvention must be named
cls, notself. Usingselfimplies aninstance method and is incorrect. This was inconsistent with
PinballLoss,LogLoss,CRPS,SquaredDistrLossandAUCalibrationin the same file, which all correctly use
cls.Classes fixed
EmpiricalCoverageIntervalWidthConstraintViolationLinearizedLogLossChange
skpro/metrics/_classes.py: 4 occurrences ofget_test_params(self)replaced with
get_test_params(cls, parameter_set="default")