[ENH] OnlineBatchMixture online regression#900
Merged
Conversation
c4360b0 to
0b589af
Compare
Contributor
Author
|
@fkiraly, @felipeangelimvieira could you plz review it. |
OnlineBatchMixture online regression
fkiraly
reviewed
May 17, 2026
fkiraly
reviewed
May 17, 2026
fkiraly
reviewed
May 17, 2026
fkiraly
requested changes
May 17, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
Very nice!
I left some small change requests.
895dd0c to
859697d
Compare
fkiraly
requested changes
May 26, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
You have not addressed my change requests.
Please ensure you also comment on change requests: either you carry them out and say so, or you ask for clarification, or you argue why you think it should not be made (e.g., out of scope).
Signed-off-by: Chaitany patel <patelchaitany93@gmail.com>
859697d to
2bb60f9
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Implemented OnlineBatchMixture from Issue #464
What does this implement/fix? Explain your changes.
Adds OnlineBatchMixture, an online regression strategy that fits a separate regressor clone on each incoming batch and returns a Mixture of predictions weighted by sample counts.
Supports a min_batch_size threshold with two modes: "accumulate" (buffer small batches) or "discard" (drop them).
Here is small example
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.