[BUG] Fix incorrect handling of negative n in BaseDistribution.head()#923
Merged
Conversation
Contributor
Author
|
Previously worked on in #895 |
Contributor
Author
|
Hi @felipeangelimvieira and @fkiraly |
fkiraly
requested changes
Apr 4, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
I think you haven't actually tried to run the code because it does not run if you try.
Is this AI generated copy-paste?
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #894
What does this implement/fix? Explain your changes.
This PR fixes incorrect handling of negative values of
ninBaseDistribution.head().The current implementation uses:
When
nis negative, this produces incorrect results.Example:
If N = 10 and n = -2, the current logic computes:
This value is then clipped to 10 and returns all rows instead of returning
all rows except the last two.
The documented behavior states:
"For negative n, returns all rows except the last n."
This PR updates the logic to:
which correctly computes the intended number of rows.
Does your contribution introduce a new dependency? If yes, which one?
No new dependencies were introduced.
What should a reviewer concentrate their feedback on?
BaseDistribution.head()nDid you add any tests for the change?
No new tests were added. Existing tests pass successfully.
Any other comments?
All existing tests pass locally after this change.
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.