Skip to content

Catalan Language resources file#144

Merged
skwasjer merged 4 commits intoskwasjer:mainfrom
UniversitatDeGirona-EquipAliga:main
Jul 7, 2023
Merged

Catalan Language resources file#144
skwasjer merged 4 commits intoskwasjer:mainfrom
UniversitatDeGirona-EquipAliga:main

Conversation

@joandomenech
Copy link
Contributor

We would like to contribute to your awesome project with the Catalan language.
Thank you very much

skwasjer
skwasjer previously approved these changes Jul 5, 2023
@skwasjer
Copy link
Owner

skwasjer commented Jul 5, 2023

@joandomenech thanks! Could you have a look at the two other resource files too? They only have 1 or 2 localizable keys. If you'd be so kind please update this PR.

src/IbanNet.DataAnnotations/Resources.resx
src/IbanNet.FluentValidation/Resources.resx

Also, make sure the resource file code generator is applied via .csproj. See this PR as an example diff I'd expect:
#97

@skwasjer skwasjer self-requested a review July 5, 2023 15:16
@joandomenech
Copy link
Contributor Author

Hello again. We also added the other resources.
Thank you

@skwasjer skwasjer merged commit 46dd781 into skwasjer:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants