fix: wildcard match does not escape special regex characters#106
Merged
fix: wildcard match does not escape special regex characters#106
Conversation
…a regex from a pattern with wildcard.
skwasjer
force-pushed
the
fix/escape_regex_special_chars
branch
from
d68c901 to
6bf1eb5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F.ex.:
path/file.jpg?width=*was previously converted to a regex@"^(path/file.jpg?width=).*". This has a few problems:.(dot) in the filename matches any character in that position, not just the dot.?makes the precedingginjpgan optional character sojpmatches just as well. In factpath/file.jpg?width=123would not actually match because after the optionalg, thewis now expected.All special regex characters are now escaped, iow. the above example would be:
@"^(path/file\.jpg\?width=).*"