Skip to content

Address several static code analysis warnings#84

Merged
skwasjer merged 12 commits intomainfrom
fix/sca
Nov 18, 2023
Merged

Address several static code analysis warnings#84
skwasjer merged 12 commits intomainfrom
fix/sca

Conversation

@skwasjer
Copy link
Owner

@skwasjer skwasjer commented Nov 18, 2023

  • fix(CA2007): ConfigureAwait the task
  • style(CA1819): properties should not return arrays
  • style(CA1037): overload accepting StringComparison
  • style(CA8602): suppress dereference possible null
  • style(CA2000): suppress because it is registered for dispose
  • style(CA2201): suppress
  • style(CA1859): change interface type to concrete type for perf.
  • style(CA1054,CA1056): change type of parameter from string to Uri.
    • The MockHttpServer.HostUrl is deprecated. Use MockHttpServer.HostUri instead.
    • The MockHttpServer ctors accepting string URL's are deprecated. Use the overloads accepting System.Uri.
  • style(CA1861): prefer 'static readonly' fields over constant array args.
  • style(CA1860): prefer comparing count to 0 rather using Any()
  • style(CA5394): do not use insecure randomness
  • style(CA1307,CA1309): Use ordinal string comparison

@skwasjer skwasjer enabled auto-merge (squash) November 18, 2023 02:21
@skwasjer skwasjer disabled auto-merge November 18, 2023 02:22
@skwasjer skwasjer enabled auto-merge (squash) November 18, 2023 02:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

92.7% 92.7% Coverage
0.0% 0.0% Duplication

@skwasjer skwasjer disabled auto-merge November 18, 2023 02:26
@skwasjer skwasjer enabled auto-merge (squash) November 18, 2023 02:26
@skwasjer skwasjer disabled auto-merge November 18, 2023 02:28
@skwasjer skwasjer enabled auto-merge (squash) November 18, 2023 02:28
@skwasjer skwasjer merged commit 038adaa into main Nov 18, 2023
@skwasjer skwasjer deleted the fix/sca branch November 18, 2023 02:57
@skwasjer skwasjer added the enhancement New feature or request label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant