Helper function: bind docker socket #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucymhdavies
pushed a commit
to LMHD/lucli
that referenced
this pull request
Jun 9, 2018
lucymhdavies
pushed a commit
to LMHD/lucli
that referenced
this pull request
Jun 9, 2018
lucymhdavies
commented
Jun 12, 2018
| } | ||
|
|
||
| // BindDockerSocket is a utility function which binds the docker socket | ||
| func (t *Task) BindDockerSocket() error { |
Author
There was a problem hiding this comment.
Might want to call this AddBindDockerSocket, to align with Bind and AddBind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. I wanna add tests for this before I consider it good, but wanted some feedback on the api.
e.g. this seems like something which should probably be a method of DockerClient rather than Task, which means I should also move Bind to be a method of DockerClient.
(Task is already a DockerClient, so wouldn't be a breaking change)