Skip to content

Prevent crashes when fragments are rapidly switched or garbage collected #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skydoves merged 1 commit into from
Jan 10, 2026
Merged

Prevent crashes when fragments are rapidly switched or garbage collected #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...w/src/main/java/com/skydoves/colorpickerview/preference/ColorPickerPreferenceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ public ColorPickerPreferenceManager clearSavedColor(String name) {
* @return {@link ColorPickerPreferenceManager}.
*/
public ColorPickerPreferenceManager setSelectorPosition(String name, Point position) {
if (position == null) {
return colorPickerPreferenceManager;
}
sharedPreferences.edit().putInt(getSelectorXName(name), position.x).apply();
sharedPreferences.edit().putInt(getSelectorYName(name), position.y).apply();
return colorPickerPreferenceManager;
Expand All @@ -110,9 +113,11 @@ public ColorPickerPreferenceManager setSelectorPosition(String name, Point posit
* @return the saved selector position.
*/
public Point getSelectorPosition(String name, Point defaultPoint) {
int defaultX = defaultPoint != null ? defaultPoint.x : 0;
int defaultY = defaultPoint != null ? defaultPoint.y : 0;
return new Point(
sharedPreferences.getInt(getSelectorXName(name), defaultPoint.x),
sharedPreferences.getInt(getSelectorYName(name), defaultPoint.y));
sharedPreferences.getInt(getSelectorXName(name), defaultX),
sharedPreferences.getInt(getSelectorYName(name), defaultY));
}

/**
Expand Down