Skip to content

SK-1597/Release/24.9.1.1 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyflow-vivek merged 5 commits into from
Sep 9, 2024
Merged

SK-1597/Release/24.9.1.1 #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5bbfa39
SK-1597 Fix card brand choice
skyflow-vivek Sep 6, 2024
d504361
Merge pull request #170 from skyflowapi/SK-1597-fix-card-brand-choice
skyflow-vivek Sep 6, 2024
78b15f3
[AUTOMATED] Private Release 1.24.0-dev.d504361
Sep 6, 2024
c02211e
SK-1597 Card brand choice
skyflow-vivek Sep 9, 2024
832da97
[AUTOMATED] Private Release 1.24.0-dev.c02211e
Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Skyflow/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ext {
mGroupId = "com.skyflowapi.android"
mArtifactId = "skyflow-android-sdk"
mVersionCode = 1
mVersionName = "1.24.0"
mVersionName = "1.24.0-dev.c02211e"

mLibraryName = "skyflow-android"
mLibraryDescription = "Skyflow’s android SDK can be used to securely collect, tokenize, and display sensitive data in the mobile without exposing your front-end infrastructure to sensitive data."
Expand Down
2 changes: 1 addition & 1 deletion Skyflow/src/main/kotlin/Skyflow/CardMetadata.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ package Skyflow

import Skyflow.collect.elements.utils.CardType

class CardMetadata(var scheme: Array<CardType>) {
class CardMetadata(var scheme: Array<CardType> = arrayOf()) {

}
8 changes: 5 additions & 3 deletions Skyflow/src/main/kotlin/Skyflow/core/elements/state/StateforText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ class StateforText internal constructor(val tf: TextField) : State(tf.columnName
}

private fun getCardSchemeString(): String {
return if (tf.cardType === CardType.EMPTY) ""
else tf.cardType.toString()
return if (tf.cardType === CardType.EMPTY || !tf.isCustomCardBrandSelected) ""
else tf.cardType.defaultName.uppercase()
}

override fun show(): String {
Expand Down Expand Up @@ -69,13 +69,15 @@ class StateforText internal constructor(val tf: TextField) : State(tf.columnName
state.put("isRequired", isRequired)
state.put("isFocused", isFocused)
state.put("isValid", isValid)
state.put("selectedCardScheme", selectedCardScheme)
var value = ""
if (env == Env.DEV) {
value = tf.getValue()
} else if (env == Env.PROD && tf.fieldType == SkyflowElementType.CARD_NUMBER) {
value = CardType.getBin(tf.getValue())
}
if (tf.fieldType == SkyflowElementType.CARD_NUMBER) {
state.put("selectedCardScheme", selectedCardScheme)
}
state.put("value", value)
return state
}
Expand Down