SK-245 development get by unique values in JAVA SDK#63
Merged
skyflow-vivek merged 6 commits intorelease/23.1.1.2from Jan 9, 2023
Merged
Conversation
skyflow-vivek
changed the title
skyflow-vivek
force-pushed
the
SK-245-development-get-by-unique-column-in-java-sdk
branch
from
8fda15a to
16a6c7a
Compare
skyflow-vivek
changed the base branch from
release/23.1.2.2
to
release/23.1.1.2
1. Modified current `getById` method to call the method by a. either using `skyflow_ids` in request params b. or using column details (`column_name` and `column_values`) in request params 2. Added validation according to the requirements of the API on top of existing validation a. throws error when neither `skyflow_ids` nor column details (`column_name` and `column_values`) are passed b. throws error when only `column_values` are passed without `column_name` c. throws error when only `comumn_name` is passed without `column_values`
skyflow-vivek
force-pushed
the
SK-245-development-get-by-unique-column-in-java-sdk
branch
from
16a6c7a to
96be494
Compare
1. Wrote unit test for `getByUniqueValues` in JAVA SDK and covered scenarios like - when method successfully returns data - when table name is not passed - when column details and ids, both are passed - when column details and ids, both are not passed - when column name is passed but not column values - when column values are pased but not column name
Added two more unit tests for `updateById` to cover - IOException - ParseException
yaswanth-pula-skyflow
approved these changes
Jan 9, 2023
skyflow-vivek
force-pushed
the
SK-245-development-get-by-unique-column-in-java-sdk
branch
from
2bcebba to
e6485d1
Compare
1. restored the `getById` to its original state 2. introduced the new `Get` interface to support both `getById` and `getbyUniqueValues` 3. Modified previously written unit tests for Get By Unique Values 4. Introduced a couple more test cases for better coverage of Get interface
skyflow-vivek
force-pushed
the
SK-245-development-get-by-unique-column-in-java-sdk
branch
from
e6485d1 to
d332654
Compare
skyflow-shravan
deleted the
SK-245-development-get-by-unique-column-in-java-sdk
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development of get method in JAVA SDK
Introduced new
Getinterface to supportgetmethod which can be invoked byskyflow_idsin request paramscolumn_nameandcolumn_values) in request paramsAdded validation according to the requirements of the API on top of existing validation
skyflow_idsnor column details (column_nameandcolumn_values) are passedcolumn_valuesare passed withoutcolumn_namecolumn_nameis passed withoutcolumn_valuesUnit Tests for Get interface In Java SDK
Wrote unit test for
getmethod in JAVA SDK and covered scenarios likeUnit Tests for Update By Id method in JAVA SDK
Added two more unit tests for
updateByIdto cover