SK-2778: Add contract testing via api-extractor snapshot#301
Merged
saileshwar-skyflow merged 3 commits intomainfrom May 5, 2026
Merged
SK-2778: Add contract testing via api-extractor snapshot#301saileshwar-skyflow merged 3 commits intomainfrom
saileshwar-skyflow merged 3 commits intomainfrom
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Devesh-Skyflow
approved these changes
May 5, 2026
skyflow-bharti
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Outcome
api-report/skyflow-node.api.md is committed as the baseline snapshot of every exported class, method signature, interface, and type in the SDK
A new Contract Tests GitHub Actions workflow runs on every PR to main and release/*, building the project and comparing the fresh API surface against the committed baseline — failing immediately if anything changes
Two npm scripts added: contract-snapshot (developer updates baseline after an intentional API change) and contract-snapshot-verify (what CI runs)
Any future rename, removal, or signature change on a public symbol is caught before merge, not after customer complaints