SK-1441/Release/24.1.2#70
Merged
skyflow-vivek merged 4 commits intomainfrom Jan 25, 2024
Merged
Conversation
Why - A bug came in Get by unique values wherein, when multiple column values are passed, multiple column name keys are appended to request url. - Due to new policy changes, any duplicate keys in request are not allowed which caused this scenario to fail and give errors. Goal - To fix this bug by changing logic in SDK for request URL creation. Testing - Additional unit tests are written to cover the new changes. - Manual testing under different scenarios has been done.
…by-unique-columns-request SK-1441 Fix Bug in Get method
yaswanth-pula-skyflow
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Goal
Testing