fix: actionable auth error UX for image inspection #115
+154
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spection When image filesystem inspection fails due to authentication (private registries), users previously saw a generic red error box with no guidance. Now the backend enriches 401 responses with registryType, and the frontend shows an AuthenticationHelp component with the specific CLI command to authenticate, a copy button, and a retry button. Closes #103
nadaverell
force-pushed
the
fix/auth-error-ux-image-inspection
branch
from
f367e80 to
6a46d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
registryType(e.g."google","aws","generic") so the frontend can show registry-specific guidance. Also added auth error detection tohandleGetFilewhich previously lacked it.ApiErrornow carries the full error responsedata. TheImageFilesystemModaldetects 401 errors and replaces the dead-end red error box with anAuthenticationHelpcomponent showing the registry hostname, the specific CLI command to authenticate (e.g.gcloud auth configure-docker,aws ecr get-login-password), a copy button, and a retry button.getRegistryHost()as a standalone utility so bothAuthenticationHelpandDownloadConfirmationcan use it.Addresses #103