fix(connecting): drop redundant 'Loading…' under 'Connecting to cluster'#551
Merged
nadaverell merged 1 commit intomainfrom Apr 27, 2026
Merged
fix(connecting): drop redundant 'Loading…' under 'Connecting to cluster'#551nadaverell merged 1 commit intomainfrom
nadaverell merged 1 commit intomainfrom
Conversation
When connection.context is empty (e.g. hub-web embedding, no kubeconfig context name), the secondary line fell back to 'Loading…' which paired with 'Connecting to cluster' above it just repeated the same information twice. Hide the secondary line when context is empty; in OSS Radar with a kubeconfig context, it still shows the cluster name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
connection.contextis empty (e.g. embedded in radar-hub-web, which doesn't pass a kubeconfig context name), the secondary line fell back to 'Loading…' — which paired with 'Connecting to cluster' above just repeated the same information.Hide the secondary line when context is empty. In OSS Radar with a kubeconfig context, it still shows the context name as before.
Note
Low Risk
Low risk UI-only change that affects the connecting screen copy; no data flow or state management logic is modified.
Overview
Removes the redundant
Loading…fallback in the connecting screen.App.tsxnow only renders the secondary line under Connecting to cluster whenconnection.contextis present, avoiding an extra placeholder line when no context name is provided (e.g., embedded mode).Reviewed by Cursor Bugbot for commit 2da5f4e. Bugbot is set up for automated code reviews on this repo. Configure here.