fix(drawer): populate Recent Events and bias toward K8s events (#547)#556
Merged
nadaverell merged 2 commits intomainfrom Apr 28, 2026
Merged
fix(drawer): populate Recent Events and bias toward K8s events (#547)#556nadaverell merged 2 commits intomainfrom
nadaverell merged 2 commits intomainfrom
Conversation
#547) The Recent Events section in the resource detail drawer was always empty. Three independent bugs combined to cause this; once they were fixed, a fourth UX issue was addressed: K8s events were being drowned out by high-frequency informer status flips on flapping resources. Root causes fixed: 1. useResourceEvents queried /api/changes with kind="pods" (URL form), but the timeline store keys events by K8s Kind ("Pod") and did not pass include_managed=true, so the default preset's IsManaged() filter dropped Pod/Event/ReplicaSet entries entirely. 2. pluralToKind("pods") was returning "PodMetrics" because initNavigationMap let the metrics.k8s.io API resource (also named "pods") overwrite the canonical Pod mapping. Fixed to be first-wins for builtins. This was a broader bug that likely affected other kind-based lookups too. 3. The package's WorkloadView never plumbed the events array into ResourceRendererDispatch (in either drawer or expanded mode), so even a correct query never reached EventsSection. Added resourceFocusedK8sEvents and resourceFocusedUpdates props through the chain. UX improvements on top: - K8s events and informer/historical updates are now fetched in two separate React Query calls with separate limits (500 vs 50). On a flapping pod the k8s_event stream cannot be starved out by an unbounded update stream. - EventsSection shows K8s events by default with a "Show N changes" toggle to fold in resource updates, with a tooltip explaining the distinction. Default is K8s-only because for most users those are the actionable signals (Pulling, Failed, BackOff, Killing, etc.). - Backend /api/changes now accepts a sources= query param (already supported internally by the timeline store, just wasn't exposed). Also removes web/src/components/shared/ResourceRendererDispatch.tsx, a wrapper that nothing imported.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a268420. Configure here.
- useResourceEvents now returns k8sError/updatesError; EventsSection renders them inline so a partial query failure doesn't render as "no events" (same silent-failure class as the original #547 bug). - /api/changes rejects invalid sources= values with 400 instead of silently returning [] (typos like "k8sevent" looked like empty). - ResourceRendererDispatch: events?: any[] -> TimelineEvent[]; same for updates. No reason for any[] now that TimelineEvent is in scope. - Add initNavigationMap regression test for the metrics.k8s.io/Pod collision — easy to "clean up" the first-wins guard without realizing. - Trim a few JSDoc/inline comments that narrated WHAT or referenced the calling site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #547.
The Recent Events section in the resource detail drawer was always empty. Three independent bugs combined to cause this — and once they were fixed, K8s events were being drowned out by informer status flips on flapping pods.
What was broken
include_managedinuseResourceEvents. The hook sent the URL kind ("pods") to a backend that filters by K8s Kind ("Pod"), and didn't passinclude_managed=trueso Pod/Event/ReplicaSet entries (whichIsManaged()flags as managed) got dropped by the default preset.pluralToKind("pods")returned"PodMetrics"becauseinitNavigationMaplet themetrics.k8s.ioAPI resource (also namedpods) overwrite the canonical Pod mapping. Fixed to make builtin mappings first-wins. This was a broader bug likely affecting other kind-based lookups in the app too.WorkloadViewnever passed aneventsprop toResourceRendererDispatchin either drawer or expanded mode — so even with a working query, the data never reachedEventsSection. AddedresourceFocusedK8sEvents/resourceFocusedUpdatesprops through the chain.UX improvement
K8s events and resource updates are now fetched in two separate queries with separate limits (500 vs 50). A flapping resource's high-frequency informer diffs can't starve out the user-meaningful K8s events.
EventsSectionshows K8s events by default with a "Show N changes" toggle (with hover tooltip explaining the distinction: changes = field-level diffs to spec/status; K8s events = messages emitted by kubelet/controllers). The drawer for a CrashLooping pod now opens with a clean list ofPulling,Failed,BackOff,Killing, etc. — not 25 lines ofErrImagePull↔ImagePullBackOffflips.Backend:
/api/changesnow accepts asources=query param. The filter already existed inpkg/timeline.QueryOptions— just wasn't exposed.Also removes
web/src/components/shared/ResourceRendererDispatch.tsx, a wrapper nothing imported.Note
Medium Risk
Touches both backend timeline querying (
/api/changes) and frontend event-fetch/rendering logic; behavior changes are scoped but could affect event visibility and API consumers if the newsourcesfilter is misused.Overview
Fixes the resource drawer’s Recent Events so it reliably populates and defaults to user-meaningful K8s events.
Backend
/api/changesnow accepts asources=query param (validated againstinformer,k8s_event,historical) to filter timeline results by origin.Frontend splits resource-focused fetching into two queries (
k8s_eventwith a high limit vsinformer/historicalwith a low limit), passes both streams (and per-stream errors) throughWorkloadView→ResourceRendererDispatch, and updatesEventsSectionto show K8s events by default with a toggle to include high-volume “changes.”Also hardens navigation kind mapping so builtin plural→kind mappings are first-wins (avoiding collisions like
podsvsPodMetrics), and removes an unusedwebwrapperResourceRendererDispatchcomponent.Reviewed by Cursor Bugbot for commit 5c3484d. Bugbot is set up for automated code reviews on this repo. Configure here.