Skip to content

feature(helm): add pod labels to helm chart#757

Merged
nadaverell merged 2 commits into
skyhook-io:mainfrom
Conor-Behard333:featature/add-pod-labels-to-helm
May 21, 2026
Merged

feature(helm): add pod labels to helm chart#757
nadaverell merged 2 commits into
skyhook-io:mainfrom
Conor-Behard333:featature/add-pod-labels-to-helm

Conversation

@Conor-Behard333
Copy link
Copy Markdown
Contributor

@Conor-Behard333 Conor-Behard333 commented May 21, 2026

Description

Updates the helm chart to allow the user to add their own "podLabels" the same way they can add their own "podAnnotations" to the radar pod.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

How has this been tested?

Describe the tests you ran to verify your changes.

  • Tested locally with minikube/kind
  • Tested against a remote cluster
  • Added/updated unit tests

Checklist

  • My code follows the project's coding standards
  • I have performed a self-review of my code
  • I have added comments where necessary
  • My changes generate no new warnings
  • Any dependent changes have been merged

Related issues

Fixes #756


Note

Low Risk
Low risk Helm chart change that only affects Kubernetes manifest metadata rendering; main risk is user-supplied podLabels unintentionally overriding/altering selector-related labels if misused.

Overview
Adds a new Helm value, podLabels, and renders it into the Deployment pod template metadata.labels (similar to existing podAnnotations).

Updates values.yaml defaults and values.schema.json so podLabels is supported and schema-validated as a string map.

Reviewed by Cursor Bugbot for commit 2e0f57a. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1fce7ca. Configure here.

Comment thread deploy/helm/radar/values.yaml
Copy link
Copy Markdown
Contributor

@nadaverell nadaverell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@nadaverell nadaverell merged commit 433743a into skyhook-io:main May 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request - Allow custom pod labels for Radar via helm deployment

2 participants