Skip to content

Fix profile refresh edge cases #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
doej13367 wants to merge 2 commits into from
Closed

Fix profile refresh edge cases #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e9ca05
Fix profile refresh edge cases
May 9, 2026
ec604e6
Use current SkyBlock asset host
May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/api/profiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { getStats } from '$lib/stats';
import type { ProfileMemberDetails, StoredProfile, StoredProfileMember } from '$mongo/collections';
import {
getStoredProfileMembers,
getStoredProfileMembersForPlayer,
profileMemberExists,
updateStoredProfile,
updateStoredProfileMember
Expand All @@ -19,6 +19,7 @@ export async function parseProfilesResponse(

for (const profile of profiles) {
const parsed = await parseProfile(profile);
parsedProfiles.push(parsed);

for (const [memberId, member] of Object.entries(profile.members)) {
const parsedMember = await parseProfileMember(profile, memberId, member);
Expand All @@ -44,7 +45,7 @@ export async function parseProfilesResponse(
}

// Mark newly missing profile members as removed for the requester
const existingProfiles = await getStoredProfileMembers(requesterUuid);
const existingProfiles = await getStoredProfileMembersForPlayer(requesterUuid);

// Update "removed" status for each profile member of the requester
for (const existing of existingProfiles) {
Expand Down
13 changes: 13 additions & 0 deletions src/db/mongo/profiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,19 @@ export async function getStoredProfileMembers(profileId: string) {
.toArray();
}

export async function getStoredProfileMembersForPlayer(playerId: string) {
playerId = playerId.replace(/-/g, '');

return await MONGO.collection(Collections.ProfileMembers)
.find<StoredProfileMember>(
{
'id.player': playerId
},
{ projection: { _id: false } }
)
.toArray();
}

export async function getStoredProfileMember(playerId: string, profileId: string) {
playerId = playerId.replace(/-/g, '');
profileId = profileId.replace(/-/g, '');
Expand Down
7 changes: 5 additions & 2 deletions src/routes/@[player=playerId]/[profile]/+page.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ export const load = (async ({ parent, params }) => {
const { profile } = params;
const { profiles, account } = await parent();

const selected =
profiles.find((p) => p.cuteName?.toUpperCase() === profile.toUpperCase() || p.id === profile) ?? profiles[0];
const selected = profiles.find((p) => p.cuteName?.toUpperCase() === profile.toUpperCase() || p.id === profile);

if (!selected) {
throw error(404, 'Profile not found!');
}

const member = await getProfileMember(account.id, selected.id);

Expand Down
4 changes: 2 additions & 2 deletions tailwind.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ export default {
}
},
backgroundImage: () => ({
'hero-pattern': 'url(https://sky.shiiyu.moe/resources/img/bg.webp)',
'footer-texture': 'url(https://sky.shiiyu.moe/resources/img/footer-texture.png)'
'hero-pattern': 'url(https://sky.shiiiyu.moe/resources/img/bg.webp)',
'footer-texture': 'url(https://sky.shiiiyu.moe/resources/img/footer-texture.png)'
}),
textShadow: {
sm: '0 1px 2px rgba(0, 0, 0, 0.1)',
Expand Down