Skip to content

Conversation

@ilyagr
Copy link
Contributor

@ilyagr ilyagr commented Aug 13, 2022

Makes Ranger plugin use the standard $ZLUA_LUAEXE and $ZLUA_SCRIPT
environment variables that z.lua, fixes error handling, adds docs.

@ilyagr
Copy link
Contributor Author

ilyagr commented Aug 13, 2022

  • Makes Ranger plugin use the standard $ZLUA_LUAEXE and $ZLUA_SCRIPT
    environment variables that z.lua itself uses so that it works out of the box
    (no need to explicitly set RANGER_ZLUA).

  • Better error handling; errors loading plugin no longer cause
    ranger to quit entirely.

  • Some minor stylistic changes to the Python code to make it more readable.

  • Briefly document the plugin

@ilyagr ilyagr force-pushed the ilya branch 3 times, most recently from fdee188 to 254a74b Compare August 13, 2022 23:12
- Makes Ranger plugin use the standard `$ZLUA_LUAEXE` and `$ZLUA_SCRIPT`
  environment variables that `z.lua` itself uses.

- Better error handling; errors loading plugin no longer cause
  `ranger` to quit entirely.

- Briefly document the plugin
@ilyagr ilyagr force-pushed the ilya branch 2 times, most recently from 83f2d0f to d4f6015 Compare August 14, 2022 01:06
@ilyagr
Copy link
Contributor Author

ilyagr commented Aug 14, 2022

I split this PR into two commits: the first one has all the important changes in a small diff. The second one consists only of stylistic changes but has a larger diff.

Let me know if I should combine them into one commit, remove the second one, etc.

@skywind3000 skywind3000 merged commit 47468a8 into skywind3000:master Aug 14, 2022
@skywind3000
Copy link
Owner

thanks

@ilyagr
Copy link
Contributor Author

ilyagr commented Aug 14, 2022

Thank you! I also realized there's a FAQ entry about ranger integration. You probably should delete the portion that says

and set environment variable in your shell rc: export RANGER_ZLUA="/path/to/z.lua"

Or, perhaps, just replace the entry with a link to the relevant portion of README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants