Debounce the search field's sl-clear event while typing
#2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 18ffc02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🕸 Website previewYou can view a preview here (commit |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds debounced search functionality to the search field component. When users type, the sl-search event is now emitted automatically after 300ms of inactivity, rather than only on Enter key press.
Key changes:
- Adds automatic debounced
sl-searchevent emission (300ms delay) during typing - Cancels debounce timer when Enter is pressed or field is cleared
- Skips emitting search events for empty/whitespace-only values
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/components/search-field/src/search-field.ts | Implements debounce timer mechanism with input listener and helper methods |
| packages/components/search-field/src/search-field.spec.ts | Adds comprehensive test coverage for debounced search behavior |
| .changeset/forty-showers-smash.md | Documents the feature change, but mentions wrong event name |
Contributor
🕸 Storybook previewYou can view a preview here (commit |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Diaan
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2766