Skip to content

Feature/2725 callout develop component #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Nov 21, 2025
Merged

Feature/2725 callout develop component #2842

merged 22 commits into from
Nov 21, 2025

Conversation

@anna-lach
Copy link
Collaborator

@anna-lach anna-lach commented Nov 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 18, 2025 07:05
@anna-lach anna-lach linked an issue Nov 18, 2025 that may be closed by this pull request
[Callout] Develop Component #2725
Closed
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: bd0166c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sl-design-system/panel Minor
@sl-design-system/callout Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot finished reviewing on behalf of anna-lach November 18, 2025 07:07
Copilot AI reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new sl-callout component to the design system for displaying additional informational content. The component is designed to be static (not dynamically shown/hidden) and supports various variants and sizes for different use cases.

Key Changes:

  • New Callout Lit component with 4 variants (info, positive, caution, negative) and 2 sizes (md, lg)
  • Comprehensive Storybook stories demonstrating various use cases including custom icons and actions
  • Basic test suite covering default behavior, variants, and title handling

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
tsconfig.all.json Added callout component to TypeScript project references
packages/components/callout/tsconfig.json TypeScript configuration for the callout component package
packages/components/callout/src/callout.ts Main component implementation with variant-based icon logic and title slot handling
packages/components/callout/src/callout.stories.ts Storybook stories demonstrating component usage with various configurations and actions
packages/components/callout/src/callout.spec.ts Unit tests for default properties, variants, and title visibility
packages/components/callout/src/callout.scss Styling with grid layout, variant-specific colors, and responsive sizing
packages/components/callout/register.ts Custom element registration for sl-callout
packages/components/callout/package.json Package manifest with dependencies and build configuration
packages/components/callout/index.ts Main entry point exporting component classes and types

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025 •
edited
Loading

🕸 Website preview

You can view a preview here (commit bd0166ca655a6aca9aa14bff8d21226e3666dfa6).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025 •
edited
Loading

🕸 Storybook preview

You can view a preview here (commit bd0166ca655a6aca9aa14bff8d21226e3666dfa6).

Copilot AI review requested due to automatic review settings November 18, 2025 07:28
Copilot finished reviewing on behalf of anna-lach November 18, 2025 07:30
Copilot AI reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.

@anna-lach anna-lach marked this pull request as ready for review November 18, 2025 07:45
Copilot AI review requested due to automatic review settings November 18, 2025 07:45
Copilot finished reviewing on behalf of anna-lach November 18, 2025 07:49
Copilot AI reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

@anna-lach
Update callout.stories.ts
845bc8d 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 18, 2025 07:50
Copilot AI review requested due to automatic review settings November 19, 2025 07:13
Copilot finished reviewing on behalf of anna-lach November 19, 2025 07:18
Copilot AI reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.

jpzwarte
jpzwarte approved these changes Nov 20, 2025
View reviewed changes
Copilot AI review requested due to automatic review settings November 20, 2025 11:06
Copilot finished reviewing on behalf of anna-lach November 20, 2025 11:07
Copilot AI reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.

Diaan
Diaan reviewed Nov 20, 2025
View reviewed changes
Copilot AI review requested due to automatic review settings November 20, 2025 14:13
Copilot finished reviewing on behalf of anna-lach November 20, 2025 14:14
Copilot AI reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings November 21, 2025 07:35
Copilot finished reviewing on behalf of anna-lach November 21, 2025 07:37
Copilot AI reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.

@anna-lach anna-lach merged commit be3b2b8 into main Nov 21, 2025
9 of 13 checks passed
@anna-lach anna-lach deleted the feature/2725-callout-develop-component branch November 21, 2025 08:36
@github-actions github-actions bot mentioned this pull request Nov 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Diaan Diaan Diaan left review comments

Copilot code review Copilot Copilot left review comments

@jpzwarte jpzwarte jpzwarte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Callout] Develop Component

4 participants

@anna-lach @jpzwarte @Diaan