-
Notifications
You must be signed in to change notification settings - Fork 6
Feature/2517 tag - improve storybook hierarchy #2848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🕸 Website previewYou can view a preview here (commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restructures the Tag component's Storybook organization by introducing a hierarchical structure and adding Tag visual regression testing to Chromatic. The changes align with established patterns used by other multi-component packages like Checkbox and Menu.
Key changes:
- Introduces a hierarchical Storybook structure: "Feedback & status/Tag" as the root with "Tag/Tag" and "Tag/Tag list" as sub-pages
- Creates a new
root.stories.tsfile containing the comprehensive "All" story for Chromatic visual regression testing - Adds Tag component to the Chromatic test suite
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/components/tag/src/tag.stories.ts |
Updates title to include hierarchical path "Tag/Tag" and comments out the "All" story (now moved to root.stories.ts) |
packages/components/tag/src/tag-list.stories.ts |
Updates title to include hierarchical path "Tag/Tag list" for consistency |
packages/components/tag/src/root.stories.ts |
New file containing the root-level Tag stories with the "All" story for Chromatic testing |
chromatic/.storybook/stories/all.stories.ts |
Adds import and export for Tag "All" story to enable Chromatic visual regression testing |
🕸 Storybook previewYou can view a preview here (commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
…ove-storybook-hierarchy
No description provided.