Skip to content

Conversation

@anna-lach
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings November 18, 2025 11:36
@anna-lach anna-lach linked an issue Nov 18, 2025 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

⚠️ No Changeset found

Latest commit: 3836a51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@anna-lach anna-lach changed the title tag structure in storybook changes, tag 'All' story added to chromatic feature/2517 tag - improve storybook hierarchy Nov 18, 2025
@anna-lach anna-lach changed the title feature/2517 tag - improve storybook hierarchy Feature/2517 tag - improve storybook hierarchy Nov 18, 2025
Copilot finished reviewing on behalf of anna-lach November 18, 2025 11:39
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

🕸 Website preview

You can view a preview here (commit 3836a5111aad356704ad0feec16dc149f692afb1).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the Tag component's Storybook organization by introducing a hierarchical structure and adding Tag visual regression testing to Chromatic. The changes align with established patterns used by other multi-component packages like Checkbox and Menu.

Key changes:

  • Introduces a hierarchical Storybook structure: "Feedback & status/Tag" as the root with "Tag/Tag" and "Tag/Tag list" as sub-pages
  • Creates a new root.stories.ts file containing the comprehensive "All" story for Chromatic visual regression testing
  • Adds Tag component to the Chromatic test suite

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/components/tag/src/tag.stories.ts Updates title to include hierarchical path "Tag/Tag" and comments out the "All" story (now moved to root.stories.ts)
packages/components/tag/src/tag-list.stories.ts Updates title to include hierarchical path "Tag/Tag list" for consistency
packages/components/tag/src/root.stories.ts New file containing the root-level Tag stories with the "All" story for Chromatic testing
chromatic/.storybook/stories/all.stories.ts Adds import and export for Tag "All" story to enable Chromatic visual regression testing

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

🕸 Storybook preview

You can view a preview here (commit 3836a5111aad356704ad0feec16dc149f692afb1).

@anna-lach anna-lach marked this pull request as ready for review November 18, 2025 11:44
Copilot AI review requested due to automatic review settings November 18, 2025 11:44
Copilot finished reviewing on behalf of anna-lach November 18, 2025 11:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@anna-lach anna-lach merged commit 2358479 into main Nov 18, 2025
10 of 13 checks passed
@anna-lach anna-lach deleted the feature/2517-tag-improve-storybook-hierarchy branch November 18, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tag] Improve Storybook Hierarchy

4 participants