Conversation
Playtest 2026-04-11 reported two adjacent OTEL dashboard bugs that share the same root cause: the dashboard's TimelineTab reads its data from the TurnComplete event in telemetry.rs::record_turn_telemetry, but several fields it depends on were missing from that event. Bug 1 — "Tier: ?" in Turn Details panel: The extraction_tier value (full / delta per ADR-066) was being emitted on the AgentSpanClose event in dispatch/mod.rs:1127, but the dashboard reads it from the TurnComplete fields. Wrong event. Net result: every Turn Details panel showed `Tier: ?` because the field simply didn't exist on the event the UI was reading. This made it impossible to tell during a playtest whether a turn was running on Full or Delta tier — critical for diagnosing prompt-cost regressions. Bug 2 — Turn # collides across sessions: Two different sessions in the same genre/world both showed `#1 narrator` rows in the Timeline, mingled together with no way to tell them apart. turn_id resets per session, but the TurnComplete event didn't carry enough metadata for the client to group rows by session. (player_id alone is insufficient — same player can play the same world twice.) Fix: add three fields to the TurnComplete WatcherEventBuilder: - extraction_tier — sourced from result.prompt_tier (closes Bug 1) - genre — sourced from ctx.genre_slug (enables session grouping) - world — sourced from ctx.world_slug (enables session grouping) Together (player_id, genre, world) form a stable session identifier the dashboard can use to draw session dividers. The companion UI fix in sidequest-ui will consume these fields to detect session boundaries when turn_id resets backwards in the timeline. Regression tests (turn_complete_telemetry_playtest_2026_04_11.rs): 1. extraction_tier field present and sourced from result.prompt_tier 2. genre and world fields present and sourced from ctx 3. All existing dashboard-required fields still present (regression guard so a future refactor can't silently drop one) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Playtest 2026-04-11 hotfix for two adjacent OTEL dashboard bugs that share the same root cause: the dashboard's TimelineTab reads from the TurnComplete event, but several required fields were missing.
Bug 1 (low) — "Tier: ?": `extraction_tier` was emitted on `AgentSpanClose` (dispatch/mod.rs:1127) instead of `TurnComplete`. Wrong event. Net result: every Turn Details panel showed `Tier: ?`.
Bug 2 (medium) — Turn # collision: Two sessions in the same world both showed `#1` rows in the timeline. `turn_id` resets per session but the event didn't carry enough metadata to distinguish them.
Fix
Add three fields to the TurnComplete WatcherEventBuilder in `telemetry.rs::record_turn_telemetry`:
`(player_id, genre, world)` is now a stable session identifier the dashboard can use to draw session dividers. Companion UI fix in slabgorb/sidequest-ui will consume these fields to detect session boundaries by watching for backward turn_id resets within a (player_id, genre, world) bucket.
Test plan
Needs restart
Yes — API restart required.
🤖 Generated with Claude Code