Skip to content

chore(sprint): mark stories 1-1 and 1-6 as done#2

Merged
slabgorb merged 1 commit intomainfrom
chore/sprint-1-6-done
Mar 25, 2026
Merged

chore(sprint): mark stories 1-1 and 1-6 as done#2
slabgorb merged 1 commit intomainfrom
chore/sprint-1-6-done

Conversation

@slabgorb
Copy link
Copy Markdown
Owner

Summary

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@slabgorb slabgorb merged commit 2bbdb31 into main Mar 25, 2026
@slabgorb slabgorb deleted the chore/sprint-1-6-done branch March 25, 2026 23:07
slabgorb added a commit that referenced this pull request Apr 6, 2026
- CLAUDE.md: update crate count (6→10), genre packs (9→11), ADR count (54→71),
  LOC/commit stats, UI/daemon directory listings, justfile commands
- wiring-diagrams.md: add narrator prompt assembly diagram (#2), rewrite combat
  diagram to remove stale keyword matching (ADR-067), update image generation with
  visual_scene/RENDER_QUEUED/throttle, enhance TTS and music sections, renumber all
  sections (1-16)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
slabgorb added a commit that referenced this pull request Apr 10, 2026
…combatant, party_reconciliation, progression

Final commit d277562 implements Architect Option A for the combatant
subsystem after three reviewer round-trips:

- consequence.wish_evaluated: emits on every evaluate() call
- combatant.bloodied: emits from state::broadcast_state_changes() (called
  from dispatch/mod.rs:1737 every turn), gated on delta.characters_changed(),
  fires when any friendly character is below half HP. Combatant trait
  reverted to telemetry-free pure accessors.
- party_reconciliation.reconciled: emits on all three reconcile() outcomes
- progression.stat_scaled: emits from level_to_hp/damage/defense

Tests: 19/19 OTEL integration + 487/487 sidequest-game lib tests GREEN.

Non-blocking improvements deferred to follow-up tickets:
- Stale doc on state.rs::lowest_friendly_hp_ratio (rework #2 carryover)
- Missing is_friendly=false negative test (defensive guard untested)
- delta.rs::to_json silent fallback (pre-existing, separate ticket)
- Wiring test rigor inconsistency across the four 35-10 subsystems
- Story 5-7 wiring debt (lowest_friendly_hp_ratio not wired into pacing)

PR slabgorb/sidequest-api#397 merged to develop.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
slabgorb added a commit that referenced this pull request Apr 25, 2026
* docs(spec): shared Room.snapshot for ADR-037 (Python port)

Design for the proper architectural fix to per-session GameSnapshot
divergence in multiplayer. Replaces the band-aid
_merge_peer_state_into_snapshot helper with a single canonical snapshot
held on SessionRoom and shared by every WS session bound to the slug.

Constraint that simplifies scope: no saved MP games exist on disk
(multiplayer has never worked end-to-end). No migration path needed.
Band-aid + its 5 merge tests are deleted in the same change.

Out of scope: ADR-028 LLM rewrites, per-recipient narration region
filtering, PlayerState overlay struct.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(plan): shared Room.snapshot implementation plan (ADR-037 Python port)

Step-by-step plan implementing the spec at
docs/superpowers/specs/2026-04-25-shared-room-snapshot-design.md.
9 tasks, 8 commits, ends at 739 passed / 2 skipped on the server +
agents sweep. Sequential single-developer plan suitable for inline
execution as the Bicycle Repair Man dev agent.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(spec): OTEL dashboard restoration design (faithful ADR-031 port)

Forensic audit found four root causes of the OTEL dashboard regression
since the Rust→Python port: broken `just otel` recipe, ~80% dead SPAN_*
constants, missing Layer-3 narrative validator, and impoverished
translator. Design specifies a four-phase faithful port that restores
full parity with the Rust contract.

Approved interactively via /superpowers:brainstorming. Self-review pass
fixed an emit-double on json_extraction_result (translator owns; not
the validator) and reclassified SPAN_CONTENT_RESOLVE to FLAT_ONLY due
to volume.

Next: writing-plans for implementation plan.

* fix(justfile): point otel recipe at playtest_dashboard.py

- Update `just otel` to call `playtest_dashboard.py` via `uv run` instead of
  the deleted `playtest.py --dashboard-only`
- Add `__main__` entry point with argparse to `playtest_dashboard.py`
  (it was a library-only module with no CLI entry point)
- Add `websockets>=12.0` and `rich>=13.0` to orchestrator `pyproject.toml`
  (required by playtest_dashboard.py, previously missing from manifest)

* ci: smoke-test the just otel recipe to catch script renames

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs(adr): ADR-090 OTEL Dashboard Restoration after Python Port

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs(adr): amend ADR-031 with Python-port section, regen indexes

Add observability tag, replace stale Rust-only opening blockquote, and
append Python-port note pointing at the canonical telemetry implementation
files in sidequest-server.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs(plan): OTEL dashboard restoration implementation plan

Pairs with the design spec at
docs/superpowers/specs/2026-04-25-otel-dashboard-restoration-design.md.
This is the 25-task plan (Phase 0–4) executed by the OTEL feat branches
across orchestrator, sidequest-server, and sidequest-ui.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(otel): Phase-2 port-audit follow-up after bundles #1 + #2

Discovered-state correction for the original Phase-2 emission-rollouts
handoff: the Python port (ADR-082) replaced most Rust info_span!/
start_as_current_span calls with logger.info(...) strings or direct
_watcher_publish calls. The SPAN_* constants in spans.py are mostly
byte-identical-to-Rust name-string prefixes, not actual span openings.

Records:
- Which families are genuinely live in Python (the ones that ship now).
- Which ~7 bundles in the original handoff are port-dead and require
  engine porting before routing.
- The two real Phase-2 workstreams: migrate live _watcher_publish sites
  (Workstream A — what bundles #49 and #50 did), vs. port the missing
  engines (Workstream B — out of scope for telemetry restoration).
- Suggested next bundle picks from Workstream A.
- Open question on whether to bridge port gaps via log-string parsing
  (recommended: no — Illusionism violation per ADR-031).

Closes the loop after PRs slabgorb/sidequest-server#49 and #50.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant