Skip to content

Fix: check that the current Celluloid actor is running before calling terminate.#137

Merged
dblock merged 1 commit intoslack-ruby:masterfrom
dblock:newdark-master
Mar 8, 2017
Merged

Fix: check that the current Celluloid actor is running before calling terminate.#137
dblock merged 1 commit intoslack-ruby:masterfrom
dblock:newdark-master

Conversation

@dblock
Copy link
Copy Markdown
Collaborator

@dblock dblock commented Mar 8, 2017

No description provided.

@dangerpr-bot
Copy link
Copy Markdown

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@dblock dblock merged commit 58a12e5 into slack-ruby:master Mar 8, 2017
@dblock dblock deleted the newdark-master branch March 8, 2017 23:21
@brand-it
Copy link
Copy Markdown

brand-it commented May 1, 2017

@dblock The link of code that it is calling is here. https://github.com/celluloid/celluloid/blob/master/lib/celluloid/task.rb#L139

@dblock
Copy link
Copy Markdown
Collaborator Author

dblock commented May 1, 2017

@NewDark Check out my spec in #147. Try putting it back, it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants