Skip to content

update to latest slack-api-ref#169

Merged
dblock merged 3 commits intoslack-ruby:masterfrom
jmanian:conversations_api
Sep 19, 2017
Merged

update to latest slack-api-ref#169
dblock merged 3 commits intoslack-ruby:masterfrom
jmanian:conversations_api

Conversation

@jmanian
Copy link
Copy Markdown
Collaborator

@jmanian jmanian commented Sep 19, 2017

There's a potentially breaking change in here, which is that they seem to have removed groups.close. I'm not sure if there's a special way to call that out on the changelog (I bolded it), or if that has implications for versioning (0.10?).

Comment thread CHANGELOG.md Outdated
@@ -1,5 +1,6 @@
### 0.9.2 (Next)

* [#169](https://github.com/slack-ruby/slack-ruby-client/pull/169): Updated to latest slack-api-ref; adds [Conversations API](https://api.slack.com/docs/conversations-api) and support for locale; **removes `groups_close`** - [@jmanian](https://github.com/jmanian).
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually just call these things as separate line items, no need to bold anything.

So

[#169](https://github.com/slack-ruby/slack-ruby-client/pull/169): Added [Conversations API](https://api.slack.com/docs/conversations-api) - [@jmanian](https://github.com/jmanian).
[#169](https://github.com/slack-ruby/slack-ruby-client/pull/169): Removed `groups_close` - [@jmanian](https://github.com/jmanian).

Comment thread bin/commands/channels.rb
g.long_desc %( Gets information about a channel. )
g.command 'info' do |c|
c.flag 'channel', desc: 'Channel to get info on.'
c.flag 'include_locale', desc: 'Set this to true to receive the locale for this channel. Defaults to false.'
Copy link
Copy Markdown
Collaborator

@dblock dblock Sep 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new, so needs a changelog line too, eg. "Added include_locale option to channels_info, rm_start, ..."

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's hidden in the middle of that one long changelog item I wrote 😉 . I'll split it up into 3 items.

@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Sep 19, 2017

This will need to bump version to 0.10.0 indeed. Want to help out and make the next release @jmanian? If yes, what's your rubygems email?

@jmanian
Copy link
Copy Markdown
Collaborator Author

jmanian commented Sep 19, 2017

Sure, I'll give it a shot. Does this give you what you need https://rubygems.org/profiles/jmanian

@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Sep 19, 2017

Sent you an invite and added to Rubygems, assigning #170 to you. Please follow https://github.com/slack-ruby/slack-ruby-client/blob/master/RELEASING.md

@jmanian
Copy link
Copy Markdown
Collaborator Author

jmanian commented Sep 19, 2017

Oh, did you want me to do the 0.10.0 bump as part of this PR?

@dblock dblock merged commit c50b8c1 into slack-ruby:master Sep 19, 2017
@jmanian jmanian deleted the conversations_api branch September 19, 2017 21:55
@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Sep 19, 2017

You can do that part of the release, no need to PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants