Use rtm.start when store is set to any subclass of Slack::RealTime::Stores::Store#172
Merged
dblock merged 1 commit intoslack-ruby:masterfrom Sep 20, 2017
Merged
Conversation
Collaborator
|
This needs a test and a CHANGELOG entry please. Might make it into 0.10.0 if you hurry :) Re: #170 |
kstole
force-pushed
the
detect_store
branch
from
85deea4 to
ac7020f
Compare
Collaborator
Author
|
Updated tests. The client_spec was a bit out of order and I didn't overhaul it fully but hopefully an improvement overall 👍 |
Collaborator
|
Very good, much thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the default
store_classisSlack::RealTime::Store, butrtm_start_methodchecks forSlack::RealTime::Stores::Storewhen selecting:rtm_start. This change allows subclasses to also use:rtm_start.