Skip to content

update to latest slack api ref#179

Closed
jmanian wants to merge 4 commits intoslack-ruby:masterfrom
jmanian:master
Closed

update to latest slack api ref#179
jmanian wants to merge 4 commits intoslack-ruby:masterfrom
jmanian:master

Conversation

@jmanian
Copy link
Copy Markdown
Collaborator

@jmanian jmanian commented Nov 20, 2017

For some reason the methods have all changed order. Any idea why?
As a result I had to redo one of the patches, chat.3, because the line numbers were no longer correct.

There's one new endpoint buried in here amongst the noise of reordering, migration.exchange.

@jmanian
Copy link
Copy Markdown
Collaborator Author

jmanian commented Nov 20, 2017

I'm looking at the diff more closely and it looks like everything used to be alphabetical, but not anymore.

@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Nov 21, 2017

I think we should add some sort somewhere and then the diff will look better and also be more predictable?

@jmanian
Copy link
Copy Markdown
Collaborator Author

jmanian commented Nov 21, 2017

I'll give that a shot.

@dblock dblock mentioned this pull request Nov 25, 2017
@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Nov 25, 2017

Replaced with #181.

@dblock dblock closed this Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants