Implementing #restart for the Celluloid Socket class.#244
Merged
dblock merged 9 commits intoslack-ruby:masterfrom Jan 18, 2019
Merged
Implementing #restart for the Celluloid Socket class.#244dblock merged 9 commits intoslack-ruby:masterfrom
dblock merged 9 commits intoslack-ruby:masterfrom
Conversation
Collaborator
|
Great, will wait for 🍏 too. |
Collaborator
Author
|
I've found a problem with my initial approach. I'm updating this PR today. |
RodneyU215
commented
Jan 17, 2019
added 8 commits
January 17, 2019 15:41
… loop into it's own Actor.
RodneyU215
commented
Jan 18, 2019
| queue.pop_with_timeout(5) | ||
| expect(@reply_to).to be 1 | ||
| end | ||
| it 'rebuilds the websocket connection when dropped' do |
Collaborator
Author
There was a problem hiding this comment.
I'm not super happy with this test, but it's been the most consistent way I've been able to validate that the reconnect works as expected for each of the 3 supported concurrency libraries.
Collaborator
Author
|
@dblock I believe this PR is ready for a review. (pending CI tests) Everything passed locally running on Ruby 2.5.3. |
Collaborator
|
I merged this, thank you. Let's see how it behaves. I need to get a bot on this code, will try to do this next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've also relocated the call to terminate the actor to the disconnect method. This finishes up the implementation so that Celluloid correctly handles restarts. See #236 for details.
Please hold off on merging though as I'm still working through testing these changes.