Make logger configurable and log socket data.#67
Merged
Conversation
Collaborator
Author
|
|
||
| def send_json(data) | ||
| fail ClientNotStartedError unless started? | ||
| logger.debug("#{self.class.name}#send_data") { data } |
Contributor
There was a problem hiding this comment.
shouldn't this be #send_json ? maybe using "#{self.class}##{__method__}" would make it automatic.
Collaborator
Author
There was a problem hiding this comment.
👍
Generally I wonder about logging data here, it's a binary blob most of the time. Thoughts?
Contributor
|
This looks great! Good job 👍 |
dblock
force-pushed
the
log-socket-data
branch
2 times, most recently
from
c152765 to
a794bfd
Compare
…as RealTime events and socket data.
dblock
added a commit
that referenced
this pull request
Mar 4, 2016
Make logger configurable and log socket data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for https://github.com/dblock/slack-ruby-client/pull/50.