Skip to content

Require minimum faraday version#81

Closed
leppert wants to merge 1 commit intoslack-ruby:masterfrom
leppert:patch-1
Closed

Require minimum faraday version#81
leppert wants to merge 1 commit intoslack-ruby:masterfrom
leppert:patch-1

Conversation

@leppert
Copy link
Copy Markdown
Contributor

@leppert leppert commented Apr 29, 2016

With Faraday <= 0.8, the following error will be thrown:

slack-ruby-client-0.7.0/lib/slack/web/api/error.rb:4:in `module:Api': superclass must be a Class (Module given) (TypeError)

With Faraday `<= 0.8`, the following error will be thrown:

slack-ruby-client-0.7.0/lib/slack/web/api/error.rb:4:in `<module:Api>': superclass must be a Class (Module given) (TypeError)
@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Apr 29, 2016

Could you check the build please? Thx.

@dblock
Copy link
Copy Markdown
Collaborator

dblock commented Oct 18, 2016

I can reproduce this, rebased and PRed as #117.

@dblock dblock closed this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants