Fix usergroups.users.{list,update} and files.commnets.{add,edit,delete} APIs#82
Fix usergroups.users.{list,update} and files.commnets.{add,edit,delete} APIs#82masatomo wants to merge 2 commits intoslack-ruby:masterfrom
Conversation
0edbed2 to
b500c48
Compare
| ### 0.7.1 (Next) | ||
|
|
||
| * Your contribution here. | ||
| * [#82](https://github.com/dblock/slack-ruby-client/pull/82): Fix usergroups.users.{list,update} and files.comments.{add,edit,delete} APIs |
There was a problem hiding this comment.
Make this look like the other entries please, quote the methods and add your - name. at the end.
|
Do I understand correctly that the implementation here of |
9d3ecf3 to
9198093
Compare
Right. refs. https://api.slack.com/methods/files.comments.edit Also, I've updated everything you pointed out. |
| ### 0.7.1 (Next) | ||
|
|
||
| * Your contribution here. | ||
| * [#82](https://github.com/dblock/slack-ruby-client/pull/82): Fix `usergroups.users.{list,update}` and `files.comments.{add,edit,delete}` APIs - [@masatomo](https://github.com/masatomo) |
There was a problem hiding this comment.
Nitpick: Missing period at the end.
|
Please check the build, you have to fix |
2cc86d4 to
2ac31a3
Compare
|
ok. but seems |
|
It shouldn't but yes, @masatomo, just make the build pass and then we shall see :) |
| ### 0.7.1 (Next) | ||
|
|
||
| * Your contribution here. | ||
| * [#82](https://github.com/dblock/slack-ruby-client/pull/82): Fix `usergroups.users.{list,update}` and `files.comments.{add,edit,delete}` APIs. - [@masatomo](https://github.com/masatomo) |
There was a problem hiding this comment.
The period is in the wrong place, should be at the end of the line :)
|
seems rubocop verison in trivis-ci is older than mine what do you want me to do? |
|
It uses what's inside Gemfile.lock, you probably have a global version and would need to run this with |
|
Merged via dblock@90e69ad. Thank you. |
|
ok, thanks! |
Some Slack APIs has 2 dots like usergroups.users.{list,update} / files.commnets.{add,edit,delete}
These APIs didn't work and this patch fixes it.