Handle received data asynchronously#93
Conversation
|
This looks good. Can you please update CHANGELOG. Could use a test maybe too? |
|
The build is breaking for some other reason (something wrong with |
|
What kind of test could I write that wouldn't be extremely nondeterministic? |
|
I would just make sure that the function implemented by the bot command is invoked via |
|
Oh, I could probably have the first command sleep indefinitely for the test. I'll try implementing that soon. |
|
OK, it looks like it'd be fairly complicated to write a test. I might be able to figure something out, but it'd definitely take a lot of digging and learning about how the library and its tests are set up. |
|
This looks good. Could you please try to fix the build or let me know if you can't? |
|
It looks like the issue is with |
|
Lock vcr to 3.0.1 in this PR? |
|
ok - but it seems like kind of an inappropriate place to do it. |
|
The issue on the vcr repo suggests that this should fix it too |
|
ok nvm, I'll just fix the vcr version. |
|
Ha, it's now failing with another issue around bundler. That's rubygems/bundler#3558 and the fix is to update bundler: before_install:
- gem update bundlerPlease. I just want this build to be green. |
|
Wait - would you prefer that I undo the last commit and just lock the vcr version, or add bundler update instead? |
|
Honestly I don't have a preference. It's just mechanics. |
|
The build is passing |
|
Merged, thanks. |
See #92.