Skip to content

Add missing ack() for command() #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaydewael merged 1 commit into from
Apr 30, 2019
Merged

Add missing ack() for command() #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/_advanced/context.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ async function addTimezoneContext ({ payload, context, next }) {
context.tz_offset = user.tz_offset;
}

app.command('request', addTimezoneContext, async ({ command, context }) => {
app.command('request', addTimezoneContext, async ({ command, ack, context }) => {
// Acknowledge command request
ack();
// Get local hour of request
const local_hour = (Date.UTC() + context.tz_offset).getHours();

Expand Down
5 changes: 4 additions & 1 deletion docs/_basic/listening_responding_commands.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ Similar to actions, there are two ways to respond to slash command requests. The

```javascript
// The echo command simply echoes on command
app.command('/echo', async ({ command, say }) => {
app.command('/echo', async ({ command, ack, say }) => {
// Acknowledge command request
ack();

say(`${command.text}`);
});
```