Skip to content

Prevent sending response headers if already sent in default error han… #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 2 commits into from
Dec 1, 2023
Merged

Prevent sending response headers if already sent in default error han… #2006

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc2a530
Prevent sending response headers if already sent in default error han…
suhailgupta03 Dec 1, 2023
9a10a61
Update log messages as per code review feedback
suhailgupta03 Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/receivers/HTTPModuleFunctions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,14 @@ export class HTTPModuleFunctions {
args: ReceiverProcessEventErrorHandlerArgs,
): Promise<boolean> {
const { error, response, logger, storedResponse } = args;

// Check if the response headers have already been sent
if (response.headersSent) {
logger.error('An unhandled error occurred after ack() called in a listener');
logger.debug(`Error details: ${error}, storedResponse: ${storedResponse}`);
return false;
}

if ('code' in error) {
// CodedError has code: string
const errorCode = (error as CodedError).code;
Expand Down