Skip to content

Add "item" interface types for "ReactionAddedEvent" #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevengill merged 4 commits into from
Jul 13, 2020
Merged

Add "item" interface types for "ReactionAddedEvent" #537

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0985a2
Add "item" interface types for "ReactionAddedEvent"
dbmikus Jul 3, 2020
dcfb6ce
Fix lint errors with double quotes vs single
dbmikus Jul 3, 2020
5124d94
Clean up TODO comment
dbmikus Jul 3, 2020
d3ad02a
Merge branch 'main' into reaction-added-item-types
dbmikus Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions src/types/events/base-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,15 +611,31 @@ export interface PinRemovedEvent extends StringIndexed {
event_ts: string;
}

interface ReactionMessageItem {
type: 'message';
channel: string;
ts: string;
}

interface ReactionFileItem {
type: 'file';
file: string;
}

// This type is deprecated.
// See https://api.slack.com/changelog/2018-05-file-threads-soon-tread
interface ReactionFileCommentItem {
type: 'file_comment';
file_comment: string;
file: string;
}

export interface ReactionAddedEvent extends StringIndexed {
type: 'reaction_added';
user: string;
reaction: string;
item_user: string;
// TODO: incomplete, should be message | file | file comment (deprecated)
// https://api.slack.com/events/reaction_added
item: {
};
item: ReactionMessageItem | ReactionFileItem | ReactionFileCommentItem;
event_ts: string;
}

Expand Down