This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Fix rightButton margin is not correctly set when autoHideRightButton …#295
Merged
dzenbot merged 1 commit intoslackhq:masterfrom Oct 26, 2015
Merged
Fix rightButton margin is not correctly set when autoHideRightButton …#295dzenbot merged 1 commit intoslackhq:masterfrom
dzenbot merged 1 commit intoslackhq:masterfrom
Conversation
ikesyo
changed the title
ikesyo
force-pushed
the
fix-rightbutton-margin
branch
from
a645837 to
6ed6b29
Compare
dzenbot
pushed a commit
that referenced
this pull request
Oct 26, 2015
Fix rightButton margin is not correctly set when autoHideRightButton …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…= NO
dceedc7#diff-592522ed60e49c6ca08c23b1fa1ac14aR104 broke the behavior.
autoHideRightButtonwould affect the result ofslk_appropriateRightButtonMargin, so we should updaterightMarginWC.constantin the setter as withrightButtonWC.constant.