Skip to content
This repository was archived by the owner on Oct 30, 2018. It is now read-only.

Add Carthage to .gitignore#493

Merged
dzenbot merged 1 commit intoslackhq:masterfrom
giginet:carthage
Jul 19, 2016
Merged

Add Carthage to .gitignore#493
dzenbot merged 1 commit intoslackhq:masterfrom
giginet:carthage

Conversation

@giginet
Copy link
Copy Markdown
Contributor

@giginet giginet commented Jul 17, 2016

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

When I installed this library by Carthage with --use-submodules option, this repository is marked as dirty because of Carthage/ is not ignored.

@dzenbot
Copy link
Copy Markdown

dzenbot commented Jul 18, 2016

This is great @giginet, although we need you to complete the Contributor License Agreement (CLA) before I can merge this PR.

@giginet
Copy link
Copy Markdown
Contributor Author

giginet commented Jul 19, 2016

Thank you!
I filled CLA. Please check it out.

@dzenbot
Copy link
Copy Markdown

dzenbot commented Jul 19, 2016

Thank you 👍

@dzenbot dzenbot merged commit 5c4fa70 into slackhq:master Jul 19, 2016
@giginet giginet deleted the carthage branch July 19, 2016 00:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants