This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Declare framework dependencies in podspec to enable compiling with ccache#666
Merged
dzenbot merged 1 commit intoslackhq:masterfrom Aug 17, 2018
Merged
Conversation
jgavris
force-pushed
the
podspec-dependencies
branch
from
92f8392 to
91ea8bb
Compare
Contributor
Author
|
Ping (perhaps @dzenbot) does this reasonable? Aiming to get all my C-language pods |
Contributor
Author
|
👋 friendly bump |
Contributor
Author
|
@dzenbot friendly bump |
jgavris
force-pushed
the
podspec-dependencies
branch
2 times, most recently
from
0c81e50 to
7e72fe5
Compare
Contributor
Author
|
@dzenbot We'd love to integrate this without forking it, any luck? |
jgavris
force-pushed
the
podspec-dependencies
branch
2 times, most recently
from
1f1ea41 to
51fafe4
Compare
dzenbot
suggested changes
Aug 17, 2018
dzenbot
left a comment
dzenbot
left a comment
There was a problem hiding this comment.
Looks good, but please remove the changes from Source/SLKTextViewController
| [self cancelAutoCompletion]; | ||
| } | ||
|
|
||
| - (void)acceptAutoCompletionWithAttributedString:(NSAttributedString *)attributedString keepPrefix:(BOOL)keepPrefix |
There was a problem hiding this comment.
This seems like a bad conflict. This method is no longer on the code base.
Contributor
Author
There was a problem hiding this comment.
Whoops, this is from our fork. I'll remove!
Users may want to build the pod with Clang modules disabled `-fno-modules` because they are using `ccache` which doesn't support `-fmodules`. When modules are disabled, auto-linking of framework modules is also disabled, so these dependencies need to be expressed explicitly.
jgavris
force-pushed
the
podspec-dependencies
branch
from
51fafe4 to
222c9dc
Compare
Contributor
Author
|
@dzenbot updated |
dzenbot
approved these changes
Aug 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Users may want to build the pod with Clang modules disabled
-fno-modulesbecause they are usingccachewhich doesn't support-fmodules. When modules are disabled, auto-linking of framework modules is also disabled, so these dependencies need to be expressed explicitly.